Make database capable of not having the complete storage #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also fixes a bug where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #131
Right now, for each block in the database, either the storage is entirely present or it is entirely absent.
In lights of #131 (comment), it is desirable to allow downloading the storage of a block over time.
In order to achieve, the database now supports inserting individual trie nodes, the idea being that we progressively download the missing trie nodes and insert them in the database over time.
When accessing the storage of a block, the database will now try to fulfill the request with what it has, and return an error if it doesn't have enough.
This PR actually overall simplifies the API of the database, as it removes some unclear corner cases related to inserting the storage of a block.