Fix database returning IncompleteStorage for next_key when node doesn't exist
#1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1483 #131
When searching for the next key within a certain prefix, the database code will currently do a next key search, then check if the output matches the requested prefix.
If the next key search doesn't succeed because some keys are missing, it returns
IncompleteStorage, even if we know that there is no result within the given prefix.This PR fixes that.
The PR is bigger than the strict minimum for the fix because I started simplifying a bit the code in prevision for checking the prefix during the iteration, then half-way through I realized that there was a much simpler solution.