Fix bug where the outer num_ignored
variable was ignored.
#44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic problem is that Rust allows move closure to capture variables if they
have a
Copy
able type, leading to the "outer" and "inner" variables to diverge.For example, this simple program:
outputs:
Note that the above program gives no warnings (or errors) in rustc or clippy.
In this case, the
num_ignored
variable had started life in single-threadedcode and later been moved to multi-threaded code. It compiled, even though the
outer variable could never be mutated. In other words, lang_tester always said
that 0 tests were ignored -- even if some were ignored!
This commit fixes this problem using an
AtomicUsize
so that ignored tests nowcount as can be seen here: