Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: Hovers show enclosing function when hovering over variable used in a macro #80

Open
mkaput opened this issue Dec 18, 2024 · 1 comment · May be fixed by #291
Open

LS: Hovers show enclosing function when hovering over variable used in a macro #80

mkaput opened this issue Dec 18, 2024 · 1 comment · May be fixed by #291
Assignees
Milestone

Comments

@mkaput
Copy link
Member

mkaput commented Dec 18, 2024

@mkaput commented on 29.10.2024, 14:46:33:

Empty project, just the following Cairo snippet:

use core::to_byte_array::FormatAsByteArray;

/// Converts a `felt252` to a `base16` (hexadecimal) string without padding, but including the `0x`
/// prefix.
/// We need this because Starknet Foundry has a way of representing addresses and selectors that
/// does not include 0's after `Ox`.
pub fn to_base_16_string_no_padding(value: felt252) -> ByteArray {
    let string = value.format_as_byte_array(16);
    format!("0x{}", str<caret>ing)
}

currently it shows:

Image

while it should not show anything (easier solution) or show proper hover for a variable

another example:
Image

@mkaput mkaput added the bug label Dec 18, 2024
@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@Arcticae commented on 7.11.2024, 12:52:06:

(Temporary) Solution:
Display nothing instead of rubbish

@mkaput mkaput moved this from Triage to Backlog in Cairo Language Services Dec 18, 2024
@mkaput mkaput added this to the Goto milestone Jan 13, 2025
@mkaput mkaput moved this from Backlog to Todo in Cairo Language Services Jan 13, 2025
@mkaput mkaput moved this from Todo to Backlog in Cairo Language Services Jan 13, 2025
@mkaput mkaput moved this from Backlog to Todo in Cairo Language Services Jan 13, 2025
@mkaput mkaput self-assigned this Jan 13, 2025
@mkaput mkaput moved this from Todo to In Progress in Cairo Language Services Feb 4, 2025
@mkaput mkaput moved this from In Progress to Todo in Cairo Language Services Feb 4, 2025
@mkaput mkaput moved this from Todo to In Progress in Cairo Language Services Feb 6, 2025
@mkaput mkaput removed the bug label Feb 10, 2025
mkaput added a commit that referenced this issue Feb 19, 2025
@mkaput mkaput linked a pull request Feb 19, 2025 that will close this issue
mkaput added a commit that referenced this issue Feb 19, 2025
mkaput added a commit that referenced this issue Feb 21, 2025
mkaput added a commit that referenced this issue Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant