From 3472960cb38ea20a6a963c47ec1fc76f0d8e4fd7 Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Wed, 22 May 2024 10:54:55 +0200 Subject: [PATCH] chore: add changes from comments --- .../com/swmansion/rnscreens/SearchBarManager.kt | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt b/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt index bacd23c578..613c41abbd 100644 --- a/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt +++ b/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt @@ -66,8 +66,8 @@ class SearchBarManager : ViewGroupManager(), RNSSearchBarManagerI } @ReactProp(name = "disableBackButtonOverride") - override fun setDisableBackButtonOverride(view: SearchBarView, value: Boolean) { - view.shouldOverrideBackButton = value != true + override fun setDisableBackButtonOverride(view: SearchBarView, disableBackButtonOverride: Boolean) { + view.shouldOverrideBackButton = disableBackButtonOverride != true } @ReactProp(name = "inputType") @@ -106,12 +106,10 @@ class SearchBarManager : ViewGroupManager(), RNSSearchBarManagerI } @ReactProp(name = "shouldShowHintSearchIcon") - override fun setShouldShowHintSearchIcon(view: SearchBarView, value: Boolean) { - view.shouldShowHintSearchIcon = value ?: true + override fun setShouldShowHintSearchIcon(view: SearchBarView, shouldShowHintSearchIcon: Boolean) { + view.shouldShowHintSearchIcon = shouldShowHintSearchIcon ?: true } - override fun setPlacement(view: SearchBarView, placeholder: String?) = Unit - override fun getExportedCustomDirectEventTypeConstants(): Map? { return MapBuilder.of( SearchBarBlurEvent.EVENT_NAME, @@ -165,6 +163,10 @@ class SearchBarManager : ViewGroupManager(), RNSSearchBarManagerI // iOS only + override fun setPlacement(view: SearchBarView, placeholder: String?) { + logNotAvailable("setPlacement") + } + override fun setHideWhenScrolling(view: SearchBarView?, value: Boolean) { logNotAvailable("hideWhenScrolling") }