NullPointerException in initDummyLayoutWithHeader

[chenxiangcxc]

Description

Hey team, we've observed a crash on Android in initDummyLayoutWithHeader with below code

        // We know the title text view will be there, cause we've just set title.
        defaultFontSize = ScreenStackHeaderConfig.findTitleTextViewInToolbar(toolbar)!!.textSize

Can we avoid the not-null assertion here? Maybe like:

        ScreenStackHeaderConfig.findTitleTextViewInToolbar(toolbar)?.let {
            defaultFontSize = it.textSize
        }

Steps to reproduce

Create an simple screen with below code

const Stack = createStackNavigator();

export default function App() {
  return (
    <NavigationContainer>
      <Stack.Navigator>
        <Stack.Screen name="GiftCards" component={TestScreen}/>
      </Stack.Navigator>
    </NavigationContainer>
  );
}

function TestScreen() {
  return (
    <View style={{ flex: 1, justifyContent: 'center', alignItems: 'center' }}>
      <Text style={{ fontSize: 24, fontWeight: 'bold' }}>Test</Text>
    </View>
  );
}

Snack or a link to a repository

https://github.com/software-mansion/react-native-screens

Screens version

4.9.1

React Native version

0.78.0

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

[github-actions]

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

[kkafar]

Hey @chenxiangcxc, do you reproduce this error reliably? I'm running your repro & it runs just fine.

Please provide me with more details, so that I can reproduce the error.

I've never observer this error when using the library daily.

[chenxiangcxc]

Hey @kkafar I can always get this issue in my project reliably but I can't tell why you can't see it.
But I am sure the crash is cause by the not-null assertion, when I remove the assertion then my app works well.

Could you have a proper change on that?