From 47de14edad86b7b7f11d084d3f6a192a3b98790d Mon Sep 17 00:00:00 2001 From: Andrew Fitzgerald Date: Fri, 29 Sep 2023 17:04:45 +0000 Subject: [PATCH] Add comment about always taking locks --- core/src/banking_stage/unprocessed_transaction_storage.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/src/banking_stage/unprocessed_transaction_storage.rs b/core/src/banking_stage/unprocessed_transaction_storage.rs index 37ab52105ee0a6..03b3e583326a71 100644 --- a/core/src/banking_stage/unprocessed_transaction_storage.rs +++ b/core/src/banking_stage/unprocessed_transaction_storage.rs @@ -177,6 +177,9 @@ fn consume_scan_should_process_packet( return ProcessingDecision::Never; } + // Always take locks during batch creation. + // This prevents lower-priority transactions from taking locks + // needed by higher-priority txs that were skipped by this check. if !payload.account_locks.take_locks(message) { return ProcessingDecision::Later; }