Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

RPC PubSub/confirmTransaction is unreliable with confirmed/singleGossip #15461

Closed
ryoqun opened this issue Feb 22, 2021 · 5 comments
Closed

RPC PubSub/confirmTransaction is unreliable with confirmed/singleGossip #15461

ryoqun opened this issue Feb 22, 2021 · 5 comments

Comments

@ryoqun
Copy link
Contributor

ryoqun commented Feb 22, 2021

Problem

Clients currently don't have nice and reliable way to follow updates to given subset's accounts.

Usually, PRC PubSub is the most straightforward solution; but we have some reports PubSub and confirmTransaction misses updates when used with commitment=confirmed/singleGossip.

It seem that the root problem is that we don't reliably send subscription notifications for that commitment level.

Also, this might be related to this old issue: #9909

Proposed Solution

Debug and fix it.

At least, provide some actionable work-around as a documentation.

CC: @jstarry @CriesofCarrots

@carllin
Copy link
Contributor

carllin commented Feb 23, 2021

hmm @CriesofCarrots is it possible here: https://github.com/solana-labs/solana/blob/master/core/src/optimistically_confirmed_bank_tracker.rs#L115-L119 that the root bank is set, purges the optimistically confirmed bank from BankForks, and then this check returns false?

@CriesofCarrots
Copy link
Contributor

@jstarry , when you have a chance, could you add some detail here from your research on this issue? I think you said the nodes in question were unhealthy and you were not able to reproduce this issue once they had been rebooted.

@CriesofCarrots
Copy link
Contributor

Regarding question above, adding a counter to see how often this occurs: #15492

@CriesofCarrots
Copy link
Contributor

I believe this was fixed in #19092

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants