This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Check for transaction forwarding delay to detect an expired transaction #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before forwarding it. Also refactored code for forwarding packets, and added test for it
aeyakovenko
approved these changes
May 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #4249 +/- ##
========================================
- Coverage 78.8% 78.4% -0.4%
========================================
Files 165 165
Lines 28610 28412 -198
========================================
- Hits 22545 22295 -250
- Misses 6065 6117 +52 |
carllin
reviewed
May 10, 2019
| @@ -577,7 +582,7 @@ impl BankingStage { | |||
| let result = bank.check_transactions( | |||
| &transactions, | |||
| &filter, | |||
| MAX_RECENT_BLOCKHASHES / 2, | |||
| (MAX_RECENT_BLOCKHASHES - MAX_TRANSACTION_FORWARDING_DELAY) / 2, | |||
There was a problem hiding this comment.
This will shorten the buffer for non-forwarded transactions as well right?
5 tasks
AshwinSekar
pushed a commit
to AshwinSekar/solana
that referenced
this pull request
Jan 4, 2025
The previous weights, which were assuming that 2% of accounts have 10 MiB of data, were filling up the whole cache with just 2369 accounts. That's very far away from the amount of cache entries on mainnet beta validators, which with default cache limits, hold around 50-60K accounts. To keep the benchmarked caches closer to the reality, assume that the 1% accounts have 300 KiB of data. With that assumption, 64356 accounts are needed to fill the cache.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The node filters out expired transactions, before forwarding them to the next node. However, the transaction can get expired while it's in flight from one node to the next. This can cause a snowball effect and cause valid transactions to be dropped.
Summary of Changes
The node that's forwarding the transaction will subtract propagation delay before filtering out expired
transactions.