Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macsec flexCounters do not work for gbsyncd, and are processed by syncd #10014

Closed
arpp93 opened this issue Feb 17, 2022 · 3 comments
Closed

Macsec flexCounters do not work for gbsyncd, and are processed by syncd #10014

arpp93 opened this issue Feb 17, 2022 · 3 comments
Assignees
Labels
MSFT Triaged this issue has been triaged

Comments

@arpp93
Copy link

arpp93 commented Feb 17, 2022

Description

Currently the key ID for MACsec objects are written to flexcounter table consumed by syncd rather than gb_flexcounter table.
This leads to SAI stats call not being called in the correct container and the PHYs in gbsyncd catering to the MACsec are not able to provide the MACsec statistics.

Steps to reproduce the issue:

  1. Configure macsec on an interface on a device running gbsyncd for phy requests.

Describe the results you received:

Jul 13 22:00:19.312125 localhost NOTICE swss#orchagent: :- createMACsecSA: MACsec SA Ethernet4:72101644409419332:2 is created.
Jul 13 22:00:19.312721 localhost ERR syncd#syncd: :- translateVidToRid: unable to get RID for VID oid:0x25c01000000003c
Jul 13 22:00:19.312787 localhost WARNING syncd#syncd: :- processFlexCounterEvent: port VID oid:0x25c01000000003c, was not found (probably port was removed/splitted) and will remove from counters now
Jul 13 22:00:19.312787 localhost WARNING syncd#syncd: :- removeMACsecSA: Trying to remove nonexisting MACsec SA oid:0x25c01000000003c
Jul 13 22:00:19.312957 localhost WARNING swss#orchagent: :- wait: got not expected response: :
Jul 13 22:00:19.313420 localhost ERR gbsyncd#GBSAI[20]: :- processFlexCounterEvent: Failed to parse the key

The syncd is trying to process the flexCounter event for a SA which exists in gbsyncd.

Describe the results you expected:

gbsyncd should be the one processing this event.

Output of show version:

Fixes of :
sonic-net/sonic-sairedis#892
sonic-net/sonic-swss#1867
are integrated in the test image.

@zhangyanzhao
Copy link
Collaborator

Ze Gan will take a look.

@zhangyanzhao zhangyanzhao added MSFT Triaged this issue has been triaged labels Mar 2, 2022
@Pterosaur
Copy link
Contributor

Thank @zhangyanzhao reminding.
Yes, it's a known issue. I estimate it can be fixed about the end of March.

@jimmyzhai
Copy link
Contributor

The issue had been fixed by sonic-net/sonic-swss#2218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MSFT Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

4 participants