Management vrf ntp support #3204
Conversation
vharish02
force-pushed
the
management_vrf_ntp_support
branch
from
6707a55 to
b8f0476
Compare
This commit adds NTP support for management VRF using L3mdev. Config vrf add mgmt will enable management VRF, enslave the eth0 device to the master device mgmt, stop ntp service in default, restart interfaces-configs and restart ntp service in mgmt-vrf context. Requirement and design are covered in mgmt vrf design document. Signed-off-by: Harish Venkatraman <[email protected]>
vharish02
force-pushed
the
management_vrf_ntp_support
branch
from
b8f0476 to
f9ef879
Compare
|
retest this please |
|
since you have changed the interface template the unit test in sonic-cfggen is broken, can you fix that? |
|
@lguohan : Changed the interfaces.j2 to resolve the same. |
|
i should have make my comments more clear before, since you have add new templates, can you add extra unit test to validate the additional configuration you have added. |
|
@lguohan : Added the extra unit test to validate the additional management vrf related configuration. Created separate files to avoid the confusion between non mgmt vrf and mgmt vrf. Let us know if this is fine. |
|
This implementation forces the NTP service to be run in the mgmt VRF when mgmt VRF is enabled. If NTP runs over Loopback0, which is configured in the default VRF and communicates through a front-panel port, it is not supported here when mgmt VRF is enabled |
|
@vharish02 Why does the loopback network interface of mgmt VRF not need to be configured ::1/128? |
…atically (#18673) #### Why I did it src/sonic-utilities ``` * 21f69fb5 - (HEAD -> 202311, origin/202311) [graceful reboot] Add watchdog, add execution of pre_reboot_hook, fix --force flag bug (#3204) (11 hours ago) [Vadym Hlushko] ``` #### How I did it #### How to verify it #### Description for the changelog
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)