Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcvrd] state machine enhancement #44

Merged
merged 6 commits into from
Sep 24, 2019
Merged

[xcvrd] state machine enhancement #44

merged 6 commits into from
Sep 24, 2019

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Sep 4, 2019

Enhance the state machine in order to overcome a possible platform temporarily fail/unavailable case

  1. When receiving system_fail event under NORMAL state, it will transmit to INIT instead of exit directly
  2. In INIT state will handle system_fail event as the same as system_not_ready event, try certain times,
    if the system recovered then transmit to NORMAL state again, if not recovered in a certain period, then exit.

the benefit of this change is that when the system has error/failed temporarily, xcvrd can survive and recover instead of exit directly, make to more tolerance to errors.

merge from Azure master
…fail/unavailable case

1. When receive system_fail event under NORMAL state, it will transmit to INIT instead of exit directly
2. In INIT state will handle system_fail event as the same as system_not_ready event,try certain times,
   if system recovered then transmit to NORMAL state again, if not covered in a certain period, then exit.

benefit of this change is that when the system has error/failed temporarily, xcvrd can survive and recover
instead of exit directly, make to more tolerance to errors.
@keboliu
Copy link
Collaborator Author

keboliu commented Sep 24, 2019

@jleveque since this gets approved, would you be able to merge this PR?

@jleveque jleveque merged commit a34ba13 into sonic-net:master Sep 24, 2019
@keboliu keboliu deleted the master-state-machine-change branch September 27, 2019 07:28
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants