-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcvrd] state machine enhancement #44
Merged
jleveque
merged 6 commits into
sonic-net:master
from
keboliu:master-state-machine-change
Sep 24, 2019
Merged
[xcvrd] state machine enhancement #44
jleveque
merged 6 commits into
sonic-net:master
from
keboliu:master-state-machine-change
Sep 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from Azure master
…fail/unavailable case 1. When receive system_fail event under NORMAL state, it will transmit to INIT instead of exit directly 2. In INIT state will handle system_fail event as the same as system_not_ready event,try certain times, if system recovered then transmit to NORMAL state again, if not covered in a certain period, then exit. benefit of this change is that when the system has error/failed temporarily, xcvrd can survive and recover instead of exit directly, make to more tolerance to errors.
jleveque
suggested changes
Sep 10, 2019
jleveque
approved these changes
Sep 11, 2019
stephenxs
approved these changes
Sep 16, 2019
@jleveque since this gets approved, would you be able to merge this PR? |
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the state machine in order to overcome a possible platform temporarily fail/unavailable case
if the system recovered then transmit to NORMAL state again, if not recovered in a certain period, then exit.
the benefit of this change is that when the system has error/failed temporarily, xcvrd can survive and recover instead of exit directly, make to more tolerance to errors.