Fix RPC package build failure due to shell syntax issue #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR sonic-net#1194 removed the .ONESHELL flag (causing all commands for a target to be executed in a single shell environment). Because of that, multi-line shell code blocks aren't parsed correctly. Since the `syncd_init_common.sh` file should always exist anyways (it's unconditionally sourced by an init script and a start script), remove the if-check around it, and always run `sed` when building rpc packages. Signed-off-by: Saikrishna Arcot <[email protected]>
kcudnik
previously approved these changes
Jul 26, 2023
saiarcot895
force-pushed
the
fix-rpc-package-build
branch
from
6f14681 to
e8f8953
Compare
|
I was hoping to add a pipeline to build the RPC version, but looks like more changes are needed there. I'll try to address that in a separate PR. |
kcudnik
approved these changes
Jul 27, 2023
|
/azp run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Jul 28, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1194 removed the .ONESHELL flag, causing commands for a target to be executed in separate shell environments. Because of that, multi-line shell code blocks aren't parsed correctly.
Since the
syncd_init_common.shfile should always exist anyways (it's unconditionally sourced by an init script and a start script), remove the if-check around it, and always runsedwhen building rpc packages.