Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cfgOrch class #144

Closed
wants to merge 1 commit into from
Closed

Add cfgOrch class #144

wants to merge 1 commit into from

Conversation

jipanyang
Copy link
Contributor

Signed-off-by: Jipan Yang [email protected]

jipan@03ed558878e7:/sonic/src/sonic-swss-common/tests$ ./tests --gtest_filter=Cfg*
Running main() from gtest_main.cc
Note: Google Test filter = Cfg*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CfgOrch
[ RUN ] CfgOrch.test
Starting cfgOrch testing

  • Step 1. Provision TEST_CONFIG_DB
  • Step 2. Verify TEST_APP_DB content
  • Step 3. Flush TEST_APP_DB
  • Step 4. Sync from TEST_CONFIG_DB
  • Step 5. Verify TEST_APP_DB content
  • Step 6. Clean TEST_CONFIG_DB
  • Step 7. Verify TEST_APP_DB content is empty
    Done.
    [ OK ] CfgOrch.test (11023 ms)
    [----------] 1 test from CfgOrch (11023 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (11023 ms total)
[ PASSED ] 1 test.

@jipanyang
Copy link
Contributor Author

Has dependency on #129

@lguohan
Copy link
Contributor

lguohan commented Oct 20, 2017

retest this please

@lguohan
Copy link
Contributor

lguohan commented Oct 20, 2017

@stcheng, cfgorch in common? I thought it should be in swss repo.

@lguohan lguohan requested review from taoyl-ms and stcheng October 20, 2017 21:39
@stcheng
Copy link
Contributor

stcheng commented Oct 20, 2017

@lguohan @JipanYanga I agree that this part shall be in the swss repository.

@jipanyang
Copy link
Contributor Author

@lguohan @stcheng intfconfd, vlanconfd and possibly other configDB swss daemons may use cfgorch class too. I'm ok to move cfgorch to swss repository, in that case I'll remove the google unit test script for it.

@lguohan
Copy link
Contributor

lguohan commented Oct 20, 2017

let's also keep the test in the swss repo.

@jipanyang
Copy link
Contributor Author

Moving cfgOrch and keeping the google unit test might be a little challenging and will take more time, googletest framework is created in swss-common.

Signed-off-by: Jipan Yang <[email protected]>
@jipanyang
Copy link
Contributor Author

Obsoleted by sonic-net/sonic-swss#360

@jipanyang jipanyang closed this Oct 25, 2017
@jipanyang jipanyang deleted the cfgorch branch June 7, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants