Replace pyswsssdk with swsscommon #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on another PR to merge first: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…uh-80/sonic-utilities into dev/liuh/update-to-swsscommon
liuh-80
commented
Jul 11, 2022
| @@ -6539,7 +6539,7 @@ def rate(): | |||
| @click.argument('rates_type', type=click.Choice(['all', 'port', 'rif', 'flowcnt-trap']), default='all') | |||
| def smoothing_interval(interval, rates_type): | |||
| """Set rates smoothing interval """ | |||
| counters_db = swsssdk.SonicV2Connector() | |||
| counters_db = SonicV2Connector() | |||
There was a problem hiding this comment.
Following API missing in sonic-swss-common:
int64_t SonicV2Connector_Native::set(const std::string& db_name, const std::string& _hash, const std::string& key, const int val, bool blocking=false);
So this PR need wait for swss-common add the missing API first.
There was a problem hiding this comment.
Create another PR to add the set method:
6 tasks
qiluo-msft
reviewed
Jul 11, 2022
| @@ -26,7 +26,6 @@ Currently, this list of dependencies is as follows: | |||
| - libyang-cpp_1.0.73_amd64.deb | |||
| - python3-yang_1.0.73_amd64.deb | |||
| - redis_dump_load-1.1-py3-none-any.whl | |||
| - swsssdk-2.0.1-py3-none-any.whl | |||
qiluo-msft
previously approved these changes
Jul 11, 2022
liuh-80
changed the title
|
The depends PR merged, so this PR is ready for review. |
qiluo-msft
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Replace sonic-py-swsssdk with sonic-swss-common.
How I did it
Update all sonic-py-swsssdk to use sonic-swss-common or sonic-py-common.
How to verify it
Pass all UT and E2E test.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)