RecordInit with an alias-type and TypeAnnotationPrinter crashes

[quentin]

Hi,
The execution of this program crashes with the debug-report enabled: souffle -F- -D- mini.dl --debug-report out.html

.type t = [x:number]
.type a = t
.decl r(v:a)
.output r
r([1]).

I found this simple fix, but I'm not sure it is the root cause. Should the alias-type be already replaced by the aliased record-type here ?

--- a/src/ast/analysis/typesystem/Type.cpp
+++ b/src/ast/analysis/typesystem/Type.cpp
@@ -531,7 +531,11 @@ void TypeAnnotationPrinter::branchOnArgument(const Argument* cur, const Type& ty
     } else if (isA<NilConstant>(*cur)) {
         print_(type_identity<NilConstant>(), *as<NilConstant>(cur));
     } else if (isA<RecordInit>(*cur)) {
+        if (auto Aliased = as<AliasType>(type)) {
+        print_(type_identity<RecordInit>(), *as<RecordInit>(cur), *as<RecordType>(Aliased->getAliasType()));
+        } else {
         print_(type_identity<RecordInit>(), *as<RecordInit>(cur), *as<RecordType>(type));
+        }
     } else if (isA<BranchInit>(*cur)) {
         print_(type_identity<BranchInit>(), *as<BranchInit>(cur));
     } else if (isA<IntrinsicFunctor>(*cur)) {

Side-question, this program is not accepted (when debug-report is disabled):

Error: Ambiguous record in file mini.dl at line 6
r([1]).
--^-----
1 errors generated, evaluation aborted

Why is that ?

--EDIT: probably related to #2063

[quentin]

I eventually found that many uses of as<RecordType>(T) and isA<RecordType>(T) don't behave as expected when T is an alias-type. Maybe a similar issue exists with ADTs ?

-- EDIT: removed the diff, I am working on a better solution.

[quentin]

replaced by #2197