Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8 and isort deprecation #11108

Closed
danieleades opened this issue Jan 7, 2023 · 3 comments
Closed

flake8 and isort deprecation #11108

danieleades opened this issue Jan 7, 2023 · 3 comments
Milestone
some future version

Comments

@danieleades
Copy link
Contributor

Ruff can now fully replace flake8 and isort in this library. Ruff is missing a couple of lints from flake-simplify, but only ones that are currently disabled anyway.
@AA-Turner
Copy link
Member

astral-sh/ruff#1718

@AA-Turner
Copy link
Member

(ruff . --select I reports 5 errors currently which isort does not agree with)

A

@danieleades
Copy link
Contributor Author

charliermarsh/ruff#1718

Good catch.

Ah well, maybe we start with flake8 then?

@AA-Turner AA-Turner added this to the some future version milestone Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
some future version
Development

No branches or pull requests
2 participants
@AA-Turner @danieleades