Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert SMB Transform test input is not re-iterated #5603

Open
clairemcginty opened this issue Feb 12, 2025 · 0 comments
Open

Assert SMB Transform test input is not re-iterated #5603

clairemcginty opened this issue Feb 12, 2025 · 0 comments
Labels
enhancement New feature or request SMB

Comments

@clairemcginty
Copy link
Contributor

SMB Transform asserts that iterable inputs to the via function are not re-iterated (https://github.com/spotify/scio/blob/v0.14.12/scio-smb/src/main/java/org/apache/beam/sdk/extensions/smb/SortedBucketSource.java#L322-L342). This is because for performance reasons, the iterable is materialized lazily, to avoid materializing the entire group in memory in case of very large key groups.

Can we wrap SMB JobTest input in an exactly-once iterable as well so that any re-iteration is caught in JobTest? I believe this can be done by wrapping the test input here.

@clairemcginty clairemcginty added enhancement New feature or request SMB labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SMB
Projects
None yet
Development

No branches or pull requests

1 participant