Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisposableFieldsShouldBeDisposedRule gives false positives on generic classes #4

Open
skolima opened this issue Sep 17, 2012 · 0 comments

Comments

@skolima
Copy link

skolima commented Sep 17, 2012

Code sample ( https://gist.github.com/3736634 ):

    public class GenericClassWithDisposableField<T> : IDisposable
    {
        private IDisposable dataTable;
        public void Dispose()
        {
            dataTable.Dispose();
        }
    }

    [Test]
    public void GenericClass_Disposal()
    {
        AssertRuleSuccess<GenericClassWithDisposableField<Object>>();
    }

This does report dataTable as not being disposed. Removing generic parameter from the parent class makes the test pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant