Skip to content

Gendarme.Rules.Maintainability.PreferStringIsNullOrEmptyRule(git)

Sebastien Pouliot edited this page Mar 2, 2011 · 1 revision

PreferStringIsNullOrEmptyRule

Assembly: Gendarme.Rules.Maintainability
Version: git

Description

This rule checks methods for cases where String.IsNullOrEmpty could be used instead of doing separate null and length checks. This does not affect execution nor performance (much) but it does improve source code readability. This rule only applies to assemblies compiled with .NET 2.0 (or later).

Examples

Bad example:

public bool SendMessage (string message)
{
    if ((message == null) || (message.Length == 0)) {
        return false;
    }
    return SendMessage (Encode (message));
}

Good example:

public bool SendMessage (string message)
{
    if (String.IsNullOrEmpty (message)) {
        return false;
    }
    return SendMessage (Encode (message));
}

Notes

  • This rule is available since Gendarme 2.0

Source code

You can browse the latest source code of this rule on github.com

Clone this wiki locally