Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test for LoggingApplicationListener's handling of a Throwable thrown from LoggingSystem#initialize #43709

Closed
wilkinsona opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

It's tested by tryingToUseJaninoWhenItIsNotOnTheClasspathFailsGracefully in LoggingApplicationListenerTests at the moment. The test relies on Logback's behavior when an attempt is made to use Janino when it isn't on the classpath. That behavior is an implementation detail of Logback and it's changed in 1.5.16. The test just needs a logging system that throws a Throwable from initialize so we should provide one so that we have complete control over its behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant