Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH agent support #15

Closed
kaithar opened this issue Aug 22, 2020 · 1 comment · Fixed by #27
Closed

SSH agent support #15

kaithar opened this issue Aug 22, 2020 · 1 comment · Fixed by #27
Assignees

Comments

@kaithar
Copy link

kaithar commented Aug 22, 2020

I'm not sure why agent support isn't popular in database clients but, at least in this case, it looks like adding it should be an easy job for someone familiar with the project.

If I'm reading correctly, you'd want to add to the configTunnel method: https://github.com/sqlectron/sqlectron-core/blob/master/src/db/tunnel.js#L73

Using this argument:

agent - string - Path to ssh-agent's UNIX socket for ssh-agent-based user authentication. Windows users: set to 'pageant' for authenticating with Pageant or (actual) path to a cygwin "UNIX socket." Default: (none)

per mscdex/ssh2

... and then do all the UI hook up that I expect will actually take the time.

@MasterOdin MasterOdin transferred this issue from sqlectron/sqlectron-core Feb 17, 2021
@maxclaus
Copy link
Member

I had implemented agent support as a first attempt to fix #25. But, went back and solved the issue with direct private key instead. Since, there is interest on this feature I am gonna add support for this after that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants