Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still MemberInjectors issue for super classes in different Gradle project #442

Closed
JohnBuhanan opened this issue Dec 8, 2021 · 4 comments · Fixed by #443
Closed

Still MemberInjectors issue for super classes in different Gradle project #442

JohnBuhanan opened this issue Dec 8, 2021 · 4 comments · Fixed by #443

Comments

@JohnBuhanan
Copy link

@RBusarow
I just tried latest SNAPSHOT, and we are closer!

I now see this when I try to build here:
https://github.com/JohnBuhanan/anvil-factory-generation-members-injector-issue

public class FeatureActivity1_MembersInjector(
  private val b1: Provider<B1>,
  private val b2: Provider<B2>,
  private val f1: Provider<F1>
) : MembersInjector<FeatureActivity1> {
  public override fun injectMembers(instance: FeatureActivity1): Unit {
    BaseActivity2_MembersInjector.injectB1(instance, b1.get())  <--- Should be BaseActivity1 I think?
    BaseActivity2_MembersInjector.injectB2(instance, b2.get())
    FeatureActivity1_MembersInjector.injectF1(instance, f1.get())
  }
...
@JohnBuhanan JohnBuhanan changed the title [Generated Factories] Another MembersInjectors for super classes issue Still MemberInjectors issue for super classes in different Gradle project Dec 9, 2021
@JohnBuhanan
Copy link
Author

And this is probably the last change I need to benchmark my build with factory generation.

I'm trying to make a case to remove dagger-reflect.

@JohnBuhanan
Copy link
Author

I'm stoked! And could I humbly request one more snapshot publish after merge?

@vRallev
Copy link
Collaborator

vRallev commented Dec 13, 2021

@JohnBuhanan I published another snapshot with the fix. I only requested minor changes before I merge the PR.

@JohnBuhanan
Copy link
Author

Beauty, I wish I could buy you guys a round of beers!

I'll go try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants