Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the runner behavior #113

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Change the runner behavior #113

wants to merge 10 commits into from

Conversation

louismerlin
Copy link
Collaborator

@louismerlin louismerlin commented Dec 9, 2024

The runner binary now only runs a single file given as argument. Ziggy handles the directory exploration, and has an option to either stop if a crash is found, or continue running inputs (default).

cargo ziggy run -i path/to/corpora/      # executes all files and does not stop on a crash
cargo ziggy run -x -i path/to/corpora/   # executes files and stops if a crash is found
# You can also use the `-r` flag for recursion
  • Move the file-discovery code from the runner harness to cargo-ziggy
  • Create the -x flag
  • Make sure the coverage generates even if there are crashes in the corpora
  • Removed unimplemented -G flag for max input length

@louismerlin louismerlin marked this pull request as ready for review December 16, 2024 10:48
@@ -217,6 +213,10 @@ pub struct Run {
/// Build with ASAN (nightly only)
#[clap(long = "asan", action)]
asan: bool,

/// Stop the run after the first crash is encountered
#[clap(short = 'x', long)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why -x? 'S' or 'C' might be more intuitive maybe? also what about timeouts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-x kind of looks like a line crashing 😄 I'm open to changing it to -C.

ziggy run reacting to timeouts is a good idea, I'll create an issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants