-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the runner behavior #113
base: main
Are you sure you want to change the base?
Conversation
@@ -217,6 +213,10 @@ pub struct Run { | |||
/// Build with ASAN (nightly only) | |||
#[clap(long = "asan", action)] | |||
asan: bool, | |||
|
|||
/// Stop the run after the first crash is encountered | |||
#[clap(short = 'x', long)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why -x? 'S' or 'C' might be more intuitive maybe? also what about timeouts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-x kind of looks like a line crashing 😄 I'm open to changing it to -C
.
ziggy run
reacting to timeouts is a good idea, I'll create an issue 👍
The runner binary now only runs a single file given as argument. Ziggy handles the directory exploration, and has an option to either stop if a crash is found, or continue running inputs (default).
cargo-ziggy
-x
flag-G
flag for max input length