Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(IconBehavior): changing icon behavior as for some cases icon could be visible #1327

Merged
merged 4 commits into from
May 22, 2019

Conversation

kolaps33
Copy link
Collaborator

During table examples implementation, we figure out icon could be visible inside the table cell. In order not narrate empty cell for user.
And if icon should behave correctly it should have role image.

@mnajdova
Copy link
Contributor

The changes looks good, but let's fist fix the failing test before final approval.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1327 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
- Coverage      73%   72.92%   -0.09%     
==========================================
  Files         775      775              
  Lines        5823     5824       +1     
  Branches     1720     1698      -22     
==========================================
- Hits         4251     4247       -4     
- Misses       1566     1571       +5     
  Partials        6        6
Impacted Files Coverage Δ
...lib/accessibility/Behaviors/Image/imageBehavior.ts 100% <ø> (ø) ⬆️
...ages/react/test/specs/behaviors/testDefinitions.ts 88.93% <100%> (-2.22%) ⬇️
...c/lib/accessibility/Behaviors/Icon/iconBehavior.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35375e3...469e44e. Read the comment docs.

@kolaps33 kolaps33 changed the title Changing icon behavior as for some cases icon could be visible fix(IconBehavior) Changing icon behavior as for some cases icon could be visible May 22, 2019
@kolaps33 kolaps33 changed the title fix(IconBehavior) Changing icon behavior as for some cases icon could be visible fix(IconBehavior): changing icon behavior as for some cases icon could be visible May 22, 2019
@kolaps33 kolaps33 merged commit 63cf45c into master May 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the mituron/icon-behavior branch May 22, 2019 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants