This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(colors): add red color scheme in Teams theme #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mnajdova
commented
May 17, 2019
•
mnajdova
commented
- added red color scheme specified by the design theme
- fixed some color schemes for the colors still not red-lined with design, in order to improve the usage showcase in the mean time
added 2 commits
May 17, 2019 10:56
-added new colors in default color scheme -refactored label variables to use inverted color scheme
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
mnajdova
commented
May 17, 2019
| @@ -40,13 +40,16 @@ export const colorScheme: ColorSchemeMapping = { | |||
| default: { | |||
| foreground: colors.white, | |||
| foreground1: colors.grey[250], | |||
| foreground3: colors.grey[300], | |||
| foreground4: colors.white, | |||
| foreground2: colors.grey[300], | |||
There was a problem hiding this comment.
Fixed wrong name of color scheme token, added two new approved by design.
mnajdova
commented
May 17, 2019
| default: { | ||
| background: color, | ||
| foreground: 'rgb(232, 232, 232)', | ||
| foreground: 'rgba(0, 0, 0, 0.6)', |
There was a problem hiding this comment.
Would really like to use here some color scheme values, because these overrides now goes to all themes (this is why we have to add labelVariables in teams and HC theme), which are actually partially copies from the light theme :(
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 72.39% 72.35% -0.05%
==========================================
Files 770 772 +2
Lines 5749 5751 +2
Branches 1680 1680
==========================================
- Hits 4162 4161 -1
- Misses 1581 1584 +3
Partials 6 6
Continue to review full report at Codecov.
|
packages/react/src/themes/teams/components/Label/labelVariables.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Label/labelVariables.ts
Outdated
Show resolved
Hide resolved
miroslavstastny
approved these changes
May 20, 2019
packages/react/src/themes/teams/components/Label/labelVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.