Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Popup): proptypes for content and trigger #1420

Merged
merged 3 commits into from
May 29, 2019

Conversation

miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented May 29, 2019

Fixes #1419.

Expected behavior (provided by PR's changes)

It is possible to use content + children.
It is not possible to use trigger + children.

Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I was about to create issue on this one, thanks for fixing!

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1420 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
+ Coverage   73.59%   73.59%   +<.01%     
==========================================
  Files         787      787              
  Lines        5888     5889       +1     
  Branches     1717     1737      +20     
==========================================
+ Hits         4333     4334       +1     
  Misses       1549     1549              
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/components/Popup/Popup.tsx 67.74% <ø> (ø) ⬆️
packages/react-proptypes/src/index.ts 33.81% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d62510...b5b4197. Read the comment docs.

@miroslavstastny miroslavstastny merged commit bd714f4 into master May 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/popup-proptypes branch May 29, 2019 14:35
bmdalex added a commit that referenced this pull request May 30, 2019
Revert "fix(Popup): proptypes for content and trigger (#1420)"

This reverts commit bd714f4.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup: PropTypes when using ChildrenAPI
2 participants