This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1682 +/- ##
=======================================
Coverage 71.06% 71.06%
=======================================
Files 862 862
Lines 7172 7172
Branches 2082 2082
=======================================
Hits 5097 5097
Misses 2069 2069
Partials 6 6 Continue to review full report at Codecov.
|
Problem: category of currently selected section cannot be collapsed anymore. |
Fixed. |
mnajdova
reviewed
Jul 19, 2019
mnajdova
reviewed
Jul 23, 2019
layershifter
approved these changes
Jul 31, 2019
7778110
to
405cdd5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a search input to the top part of sidebar. The search goes through all the below tree's sections, effectively filtering those that match the query. The items are matched in case-insensitive fashion.
As you can see, the icon is not rendered at an expected position. This looks like a bug in Input component, reported here.
The search input is not fully accessible - it does not let the user know, how many items were found (matching the query). This would be solved in a future PR.
You can search by typing even when the element is not focused (provided no other input element is in focus).