Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Toolbar): close menu when it looses focus #1688

Merged
merged 9 commits into from
Jul 26, 2019

Conversation

sophieH29
Copy link
Contributor

Fixes #1624

@sophieH29 sophieH29 added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. accessibility All the Accessibility tasks and bugs should be tagged with this. labels Jul 19, 2019
@sophieH29 sophieH29 self-assigned this Jul 19, 2019
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1688 into master will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
- Coverage   70.95%   70.92%   -0.03%     
==========================================
  Files         860      860              
  Lines        7144     7148       +4     
  Branches     2076     2077       +1     
==========================================
+ Hits         5069     5070       +1     
- Misses       2069     2072       +3     
  Partials        6        6
Impacted Files Coverage Δ
...kages/react/src/components/Toolbar/ToolbarItem.tsx 45.61% <0%> (-2.54%) ⬇️
...ssibility/Behaviors/Toolbar/toolbarItemBehavior.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b21ea8...29ebf43. Read the comment docs.

@jurokapsiar
Copy link
Contributor

I have tested this - tab correctly closes the menu, but shift+tab focuses the triggering button and the menu is not closed

@vercel vercel bot temporarily deployed to staging July 26, 2019 10:08 Inactive
@mnajdova
Copy link
Contributor

Actually, with the latest changes, shift tab is focusing the trigger element :\ Can you check this again

@sophieH29 sophieH29 merged commit 7da5268 into master Jul 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/toolbar-menu-close-on-blur branch July 26, 2019 12:45
sophieH29 added a commit that referenced this pull request Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. 🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar menu does not close when it loses focus
3 participants