This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
fix(Toolbar): close menu when it looses focus #1688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
==========================================
- Coverage 70.95% 70.92% -0.03%
==========================================
Files 860 860
Lines 7144 7148 +4
Branches 2076 2077 +1
==========================================
+ Hits 5069 5070 +1
- Misses 2069 2072 +3
Partials 6 6
Continue to review full report at Codecov.
|
I have tested this - tab correctly closes the menu, but shift+tab focuses the triggering button and the menu is not closed |
sophieH29
commented
Jul 26, 2019
packages/react/src/lib/accessibility/Behaviors/Toolbar/toolbarItemBehavior.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jul 26, 2019
packages/react/src/lib/accessibility/Behaviors/Toolbar/toolbarItemBehavior.ts
Show resolved
Hide resolved
jurokapsiar
approved these changes
Jul 26, 2019
mnajdova
approved these changes
Jul 26, 2019
Actually, with the latest changes, shift tab is focusing the trigger element :\ Can you check this again |
sophieH29
added a commit
that referenced
this pull request
Jul 26, 2019
This reverts commit 7da5268.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accessibility
All the Accessibility tasks and bugs should be tagged with this.
🧰 fix
Introduces fix for broken behavior.
🚀 ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1624