This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
commented
Jul 22, 2019
jurokapsiar
commented
Jul 22, 2019
jurokapsiar
commented
Jul 22, 2019
jurokapsiar
commented
Jul 22, 2019
jurokapsiar
commented
Jul 22, 2019
packages/react/src/lib/accessibility/Behaviors/ContextMenu/contextMenuBehavior.ts
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 2, 2019
docs/src/examples/components/MenuButton/Rtl/MenuButtonExample.rtl.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 2, 2019
docs/src/examples/components/MenuButton/Rtl/MenuButtonExample.rtl.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 2, 2019
docs/src/examples/components/MenuButton/Usage/MenuButtonExampleControlled.shorthand.tsx
Outdated
Show resolved
Hide resolved
jurokapsiar
commented
Aug 5, 2019
mnajdova
reviewed
Aug 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
- Coverage 69.94% 69.89% -0.05%
==========================================
Files 863 867 +4
Lines 7286 7338 +52
Branches 2110 2147 +37
==========================================
+ Hits 5096 5129 +33
- Misses 2183 2201 +18
- Partials 7 8 +1
Continue to review full report at Codecov.
|
layershifter
reviewed
Aug 8, 2019
layershifter
reviewed
Aug 8, 2019
docs/src/examples/components/MenuButton/State/MenuButtonExampleControlled.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 8, 2019
docs/src/examples/components/MenuButton/State/MenuButtonExampleControlled.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Aug 8, 2019
layershifter
reviewed
Aug 8, 2019
layershifter
reviewed
Aug 8, 2019
layershifter
reviewed
Aug 8, 2019
layershifter
reviewed
Aug 8, 2019
layershifter
reviewed
Aug 8, 2019
layershifter
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows opening a "dropdown" menu on left/right click, hover or focus.
Reuses Popup, adds a Menu to its content.
Fixes #345