chore(Tree): rename to HierarchicalTree #1752
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 868 868
Lines 7335 7335
Branches 2142 2119 -23
=======================================
Hits 5133 5133
Misses 2196 2196
Partials 6 6
Continue to review full report at Codecov.
|
| @@ -75,7 +75,7 @@ export { default as ToolbarMenu } from './components/Toolbar/toolbarMenuVariable | |||
| export { default as ToolbarMenuDivider } from './components/Toolbar/toolbarMenuDividerVariables' | |||
| export { default as ToolbarMenuItem } from './components/Toolbar/toolbarMenuItemVariables' | |||
|
|
|||
| export { default as TreeTitle } from './components/Tree/treeTitleVariables' | |||
| export { default as TreeTitle } from './components/HierarchicalTree/hierarchicalTreeTitleVariables' | |||
packages/react/src/themes/types.ts
Outdated
| Tree?: TreeProps | ||
| TreeItem?: TreeItemProps | ||
| TreeTitle?: TreeTitleProps | ||
| Tree?: HierarchicalTreeProps |
| @@ -70,11 +70,11 @@ const checkOpenTitles = (wrapper: ReactWrapper, expected: string[]): void => { | |||
| } | |||
|
|
|||
| describe('Tree', () => { | |||
| @@ -3,7 +3,7 @@ import * as _ from 'lodash' | |||
| import * as PropTypes from 'prop-types' | |||
There was a problem hiding this comment.
Where / how can we mark as depreciated?
There was a problem hiding this comment.
Created request #1756 to properly handle depreciated methods in DocSite. For now, can we update text descriptions to make this clear.
There was a problem hiding this comment.
should we do this in the current PR?
There was a problem hiding this comment.
In the current PR, just put (DEPRECATED) to the beginning of the description of the Tree. See https://stardust-ui.github.io/react/components/item-layout as an example.
There was a problem hiding this comment.
We should also provide console warnings when using deprecated components/props once we ship the new Tree.
silviuaavram
force-pushed
the
chore/rename-tree
branch
from
6ad3315 to
738422a
Compare
Renamed
TreetoHierarchicalTree,TreeItemtoHierarchicalTreeItemandTreeTitletoHierarchicalTreeTitle.Renamed
treeBehaviortohierarchicalTreeBehavior,treeItemBehaviortohierarchicalTreeItemBehavior,treeTitleBehaviortohierarchicalTreeTitleBehaviorandsubtreeBehaviortohierarchicalSubtreeBehavior.BREAKING CHANGE MITIGATION
Perform the renames where the components and behaviors are used.