This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
reviewed
Aug 5, 2019
Co-Authored-By: Pavel Lučivňák <[email protected]>
…com/stardust-ui/react into chore/event-listener # Conflicts: # CHANGELOG.md
…com/stardust-ui/react into chore/event-listener # Conflicts: # CHANGELOG.md
miroslavstastny
approved these changes
Aug 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 70.02% 69.94% -0.08%
==========================================
Files 868 863 -5
Lines 7335 7286 -49
Branches 2119 2133 +14
==========================================
- Hits 5136 5096 -40
+ Misses 2193 2183 -10
- Partials 6 7 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
StackableEventListener
component is removed as it was never used.Changes
EventListener
has proper type-checks now:EventListener
usesuseEventListener()
, that allows to simplify code drastically and remove unused things