Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

chore(EventListener): use hooks #1755

Merged
merged 10 commits into from
Aug 8, 2019
Merged

chore(EventListener): use hooks #1755

merged 10 commits into from
Aug 8, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 4, 2019

BREAKING CHANGES

StackableEventListener component is removed as it was never used.

Changes

  • EventListener has proper type-checks now:
<EventListener type="click" listener={(e /* resolved to MouseEvent */) => {} />
  • EventListener uses useEventListener(), that allows to simplify code drastically and remove unused things

Co-Authored-By: Pavel Lučivňák <[email protected]>
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #1755 into master will decrease coverage by 0.07%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
- Coverage   70.02%   69.94%   -0.08%     
==========================================
  Files         868      863       -5     
  Lines        7335     7286      -49     
  Branches     2119     2133      +14     
==========================================
- Hits         5136     5096      -40     
+ Misses       2193     2183      -10     
- Partials        6        7       +1
Impacted Files Coverage Δ
...ckages/react-component-event-listener/src/index.ts 100% <ø> (ø) ⬆️
...eact-component-event-listener/src/EventListener.ts 77.77% <77.77%> (-22.23%) ⬇️
...t-component-event-listener/src/useEventListener.ts 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1443f...3a68bd7. Read the comment docs.

@layershifter layershifter merged commit f9e53a4 into master Aug 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/event-listener branch August 8, 2019 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants