This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Button): renderIcon prop #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
fix/button-icon-render
branch
from
fa3c0a3 to
488b4f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 64 64
Lines 1237 1237
Branches 157 180 +23
=======================================
Hits 1110 1110
Misses 125 125
Partials 2 2
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Oct 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
renderIconprop is passed to the Icon's defaultProps by mistake. This should be passed as an option to the factory. This PR fixes this issue.