Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating PEPs can be extremely slow due to numpy OMP multiprocessing #13

Closed
MatthewThe opened this issue Nov 4, 2020 · 2 comments
Closed

Comments

@MatthewThe
Copy link
Contributor

MatthewThe commented Nov 4, 2020

On some systems (e.g. Ubuntu), calculating PEPs with getQvaluesFromScores is extremely slow (more than 1 minute instead of just a few seconds) when OMP multithreading is not disabled for numpy. This can be circumvented by prepending the call to Triqler/Qvality by OMP_NUM_THREADS=1. I'm not sure yet which of the numpy functions is causing this, but it's most likely one of the matrix functions used in the IRLS.

def getQvaluesFromScores(targetScores, decoyScores, includePEPs = False, includeDecoys = False, tdcInput = False, pi0 = 1.0, plotRegressionCurve = False, numBins = 500):

@wfondrie
Copy link

wfondrie commented Mar 3, 2022

@MatthewThe - any idea on a timeline for a new release containing this PR?

@MatthewThe
Copy link
Contributor Author

Sorry, updating the package is indeed long overdue. I will try to make a new release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants