Further EXTI cleanups/enhancements #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Thank you, @jonas-schievink, this looks good!
Regarding your commit moving the documentation to the trait: I'd much prefer if the trait didn't exist and there was just a struct with a constructor that took ownership of EXTI. This would follow the style of many other peripheral APIs. I don't expect you to do this (your PR is great as-is), but your commit reminded me of that, so I thought I'd mention it.
|
(Travis failure is unrelated to this PR, and already fixed in #66) |
|
Yeah, moving EXTI to a wrapper struct makes sense to me. I think the API was this way because there's no need to initialize anything here (unlike for timers, serial, etc.) so the raw EXTI can be immediately used. |
It's not large enough to warrant 2 levels of modules
They're easy to find there
Would be nice to be able to just pass a pin you own, but this will do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.