-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the package name in the file upload doc #3795
Conversation
The package `strawberry` was referenced, but that's another project, this one is `strawberry-graphql`.
Reviewer's Guide by SourceryThis pull request fixes a typo in the file upload documentation, correcting the package name from No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lindycoder - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good catch, documentation updates like this are very helpful for users.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Question: There are some incorrect references in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops! thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops! thanks!
@lindycoder yes please 😊 |
@patrick91 Done :) |
Description
The package
strawberry
was referenced, but that's another project, this one isstrawberry-graphql
.Types of Changes
Summary by Sourcery
Documentation:
strawberry-graphql
) instead ofstrawberry
.