This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix memory leak and optimize memory usage #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* There is a memory leak in MessageRecordUtils. *Modifications* - Fix the memory leak in MessageRecordUtils - Avoid memory allocation when serializing the response - Optimize the reference counting for kafka request holding the payload reference
jiazhai
approved these changes
Feb 6, 2020
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Oct 30, 2023
) Master issue: streamnative/ksn#63 ### Modifications Replace the `KafkaRequestAndHeader` with the `InflightRequest` implementation, which supports storing a raw buffer without parsing it to an `AbstractRequest`. For `FindCoordinator` request, since the proxy itself can act as the coordinator broker, just return a success response without forwarding the request to broker. Based on the `InflightRequest`, forwarding the following requests directly to a group coordinator broker, which is unique for a specific consumer: - JoinGroup - SyncGroup - LeaveGroup - OffsetFetch - OffsetCommit - Heartbeat Then, handles the `ListOffsets` and `Fetch` requests by forwarding them to leader broker. Add `testConsume` to verify it works. ### Next step - Add an integration test to verify the Kafka port (9092) won't be accessed by Kafka clients when connecting proxy - Support `ListOffsets` and `Fetch` requests with multiple brokers - (low priority) Support `ListOffset` v0 request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a memory leak in MessageRecordUtils.
Modifications