-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set leaflet NoWrap and bounds to prevent map & layers from repeating #2577
base: main
Are you sure you want to change the base?
Conversation
@corylown The zoom is still doing odd things compared to the legacy viewer |
@dnoneill I suspect that has to do with the different size/shape of the map container in the new viewer. There's a way to increase the zoom beyond what gets calculated by leaflet via |
Could this cause problems for any datasets that span 180 longitude? I know the Aleutian island chain crosses 180. Do we have any data like that to test on? |
@corylown I agree. I think just making sure we have the information recorded somewhere since it is not just Andrew who is a stakeholder and if a geo stakeholder has questions about this, I would like to have an answer recorded somewhere. |
gk831nh0251 is a good test item for crossing 180. |
@corylown I think there is something wrong with the calculations. I think the calculations for the area to zoom to need to be done after we know if the sidebar is open or not. This is the view of gk831nh0251 with the sidebar open vs closed. As you can see the data on the right is showing up only after you close the sidebar. Also I think this crossing 180 is an okay. I am also including a world repeat in this and it looks pretty similar. |
@dnoneill I can't duplicate what you're seeing. When I load https://purl.stanford.edu/gk831nh0251 in the new geo viewer the map is loading at the correct size so the data on the far left and right is all visible: ![]() |
@corylown seems to be dependent on browser size. |
10faed2
to
87a5a4d
Compare
Fixes #2550
Before:

After:
