Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra grid cells for parent folder #2591

Open
dnoneill opened this issue Feb 20, 2025 · 4 comments
Open

extra grid cells for parent folder #2591

dnoneill opened this issue Feb 20, 2025 · 4 comments

Comments

@dnoneill
Copy link
Contributor

dnoneill commented Feb 20, 2025

In the new file viewer, the parent folder is being constrained. It should cover the full row. Getting rid of the extra gridcells does not fix it. However I am guessing this is related to the issue.

https://sul-purl-uat.stanford.edu/fg478vy8624?new_viewer=true

Image

Image

@jcoyne
Copy link
Contributor

jcoyne commented Feb 20, 2025

I don't believe this is just in the new viewer. It's in the legacy viewer too.

Image

@jcoyne
Copy link
Contributor

jcoyne commented Feb 20, 2025

I think keeping the folder in the column is the expected behavior of tables. I don't think it should extend into the size column. That would be confusing and make it difficult to scan the table when you're looking for file size data.

@dnoneill
Copy link
Contributor Author

Maybe this is font size difference? If I look at the old/new viewer in the same size browser it does not cut off.

Image Image

@jcoyne
Copy link
Contributor

jcoyne commented Feb 20, 2025

Yes, I think it would cut off eventually if you encountered a long enough folder name. The font and icon size does appear to have changed some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants