Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize ref forwarding #526

Closed
2 tasks done
connor-baer opened this issue Jan 21, 2020 · 1 comment
Closed
2 tasks done

Standardize ref forwarding #526

connor-baer opened this issue Jan 21, 2020 · 1 comment
Labels
feature A new feature or enhancement help wanted Looking for contributions
Milestone
v2.0

Comments

@connor-baer
Copy link
Member

connor-baer commented Jan 21, 2020 •
edited
Loading

Follow up to #346.

Motivation

Using references in React has changed over time and different libraries have used different approaches. Some Circuit UI components accept a deepRef or innerRef prop to forward a ref. React has since released a native API: forwardRef

Tasks

  • wrap all functional components in the native forwardRef (styled components do this automatically)
  • document a convention for components with several child nodes: which node should receive the ref?

Originally posted by @felixjung in #342 (comment)
@connor-baer connor-baer added this to the v2.0 milestone Jan 21, 2020
@connor-baer connor-baer mentioned this issue Jan 21, 2020
Closed
@connor-baer connor-baer added help wanted Looking for contributions feature A new feature or enhancement and removed roadmap labels Jan 28, 2020
@nicosommi nicosommi mentioned this issue May 19, 2020
Merged
5 tasks
@connor-baer
Copy link
Member Author

Closed by #592.

@robinmetral robinmetral mentioned this issue Jun 11, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature or enhancement help wanted Looking for contributions
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@connor-baer