_ts_dispose_resources is not correctly invoked for using keyword

[jtbandes]

Describe the bug

The Symbol.dispose function is not invoked when using the using keyword.

The output includes

finally{
    _ts_dispose_resources(env);
}

However, this function is defined as

function _ts_dispose_resources(SuppressedError1) {
    return function(env) {
        // ...
    };
}

So calling _ts_dispose_resources(env); does not actually invoke the dispose logic.

The function does seem to be invoked here, so something else must be going wrong:

swc/crates/swc_ecma_transforms_base/src/helpers/_ts_dispose_resources.js

Line 32 in 8f45eaf

})(env);

Input code

using x = {
  [Symbol.dispose]() {
    console.log("disposed")
  }
};

Config

{
  "jsc": {
    "parser": {
      "syntax": "ecmascript",
      "jsx": false,
      "explicitResourceManagement":true
    },
    "target": "es2022",
    "loose": false,
    "minify": {
      "compress": false,
      "mangle": false
    }
  },
  "module": {
    "type": "commonjs"
  },
  "minify": false,
  "isModule": true
}

Playground link (or link to the minimal reproduction)

https://play.swc.rs/?version=1.7.39&code=H4sIAAAAAAAAAystzsxLV6hQsFWo5lJQiA6uzE3Kz9FLySwuyC9OjdXQBAsrKCTn5xXn56Tq5eSnayhBZVOUNIFytVy11gBoxdWzRQAAAA%3D%3D&config=H4sIAAAAAAAAA1VPOw6DMAzdOQXyzFAx9g4svYGVGhSUn2IjgRB3bxIgbbe8f7w3bQszK3i2e3omEDAyxYoTw5sTXBMDpCyyijoIdLc6c5ZGNEwd0BqMVlpexH6JigZ0OJElJ%2FCUuFAJHWcWBONEUnq5f%2FT91QnGe6baeXJWOz1uv79S3oZIzP%2FGbEU3mZo%2FF5trFax%2FL0W8rpUtZJTbrHczw9d5L9Z20Dzc8XLM8QEIU%2BriPgEAAA%3D%3D

SWC Info output

No response

Expected behavior

console.log("disposed") should run

Actual behavior

No log message

Version

1.7.39

Additional context

See also #9576

[kdy1]

Investigation:

helpers/Marker (resolver for injected inline helpers) seems to be the cause.

swc/crates/swc_ecma_transforms_base/src/helpers/mod.rs

Lines 549 to 630 in 70fcbc4

	struct Marker {
	base: SyntaxContext,
	decls: FxHashMap<JsWord, SyntaxContext>,
	decl_ctxt: SyntaxContext,
	}
	impl VisitMut for Marker {
	noop_visit_mut_type!();
	fn visit_mut_fn_decl(&mut self, n: &mut FnDecl) {
	let old_decl_ctxt = replace(
	&mut self.decl_ctxt,
	SyntaxContext::empty().apply_mark(Mark::new()),
	);
	let old_decls = self.decls.clone();
	n.visit_mut_children_with(self);
	self.decls = old_decls;
	self.decl_ctxt = old_decl_ctxt;
	}
	fn visit_mut_fn_expr(&mut self, n: &mut FnExpr) {
	let old_decl_ctxt = replace(
	&mut self.decl_ctxt,
	SyntaxContext::empty().apply_mark(Mark::new()),
	);
	let old_decls = self.decls.clone();
	n.visit_mut_children_with(self);
	self.decls = old_decls;
	self.decl_ctxt = old_decl_ctxt;
	}
	fn visit_mut_ident(&mut self, i: &mut Ident) {
	i.ctxt = self.decls.get(&i.sym).copied().unwrap_or(self.base);
	}
	fn visit_mut_member_prop(&mut self, p: &mut MemberProp) {
	if let MemberProp::Computed(p) = p {
	p.visit_mut_with(self);
	}
	}
	fn visit_mut_param(&mut self, n: &mut Param) {
	if let Pat::Ident(i) = &n.pat {
	self.decls.insert(i.sym.clone(), self.decl_ctxt);
	}
	n.visit_mut_children_with(self);
	}
	fn visit_mut_prop_name(&mut self, n: &mut PropName) {
	if let PropName::Computed(e) = n {
	e.visit_mut_with(self);
	}
	}
	fn visit_mut_super_prop(&mut self, p: &mut SuperProp) {
	if let SuperProp::Computed(p) = p {
	p.visit_mut_with(self);
	}
	}
	fn visit_mut_var_declarator(&mut self, v: &mut VarDeclarator) {
	if let Pat::Ident(i) = &mut v.name {
	if &*i.sym == "id" || &*i.sym == "resource" {
	i.ctxt = self.base;
	self.decls.insert(i.sym.clone(), self.base);
	return;
	}
	if !i.sym.starts_with("__") {
	self.decls.insert(i.sym.clone(), self.decl_ctxt);
	}
	}
	v.visit_mut_children_with(self);
	}
	}

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.