-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panes misalign when handling combining characters in directory names #2116
Comments
My knowledge of Unicode is quite limited, and I've never used these characters myself, so it's hard to say how to fix this. I'll add the "help wanted" tag and count on the community to help with this. |
Note that Yazi doesn't handle text rendering itself, but relies on the underlying TUI framework It might be related to or a duplicate of #1714 |
Looks like it's problem with wezterm - not reproducible in powershell or gitbash or terminal with powershell inside, in wezterm reproduce every time |
Thanks for the information @ViktorKarpilov ! Hey @JustForFun88 , could you verify if this is a WezTerm-specific issue? Does it reproduce in other terminals, like the latest MS Terminal Preview? |
Hmm... Maybe it really is because of the terminal emulator. I can reproduce this bug in |
It's likely that the older versions of WezTerm and MS Terminal were using an old ConPTY implementation, while the latest MS Terminal preview is using the updated ConPTY. The new ConPTY properly supports this feature. In this case, I believe that with future updates to WezTerm, using the new ConPTY will resolve the issue. Since this involves ConPTY, I guess it's a Windows-specific problem, and it might not exist on other systems like Linux or macOS. |
I’m going to close this for now because it really looks like a terminal problem. Since Yazi itself doesn't handle text rendering, I'm not sure how to fix it within Yazi. Plus, I've never used these characters myself, which makes it not doable for me. Feel free to reopen it or create a new issue if anyone figures out how to solve this. Thanks! |
I'm going to lock this issue because it has been closed for 30 days. ⏳ |
What system are you running Yazi on?
Windows
What terminal are you running Yazi in?
wezterm 20240203-110809-5046fc22
yazi --debug
outputDescribe the bug
The bug occurs when a directory name contains combining characters (e.g.,
COMBINING BREVE (U+0306)
,COMBINING ACUTE ACCENT (U+0301)
and so on). This causes the panes in yazi to render incorrectly after navigating to or past such directories.The bug manifests as follows:
The effect resembles "refraction" when crossing boundaries, with panels "breaking" at the boundary between two mediums. This results in a distorted layout, overlapping panes, and persistent rendering artifacts.
This behavior is observed with directory names containing Unicode combining characters, such as:
Minimal reproducer
For example, here I created a directory with the name of the book:
stacked̀̂
(à̂ = U+0061 + U+0300 + U+0302, COMBINING GRAVE ACCENT + COMBINING CIRCUMFLEX ACCENT). But it is not necessary to have exactly two symbols. Let's sayГолицынский Ю.Б.
is also enough.Screen.Recording.2024-12-29.143637.mp4
Anything else?
No response
Checklist
yazi --debug
) input box to the nightly that I triedmv ~/.config/yazi ~/.config/yazi-backup
)The text was updated successfully, but these errors were encountered: