From 530eed54c0408e1f0e18e2e59cc372ec2d82d47b Mon Sep 17 00:00:00 2001 From: wesoledi Date: Mon, 15 Aug 2022 13:01:37 +0200 Subject: [PATCH 1/2] 2022-08-15 - move const def under main condition - do not init if not nessesary --- lib/plugins/eslint.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/plugins/eslint.js b/lib/plugins/eslint.js index fa9053fe..2291411e 100644 --- a/lib/plugins/eslint.js +++ b/lib/plugins/eslint.js @@ -9,13 +9,6 @@ 'use strict'; -const forceSync = require('sync-rpc'); -const hasEslintConfiguration = forceSync(require.resolve('../utils/has-eslint-configuration')); -const WebpackConfig = require('../WebpackConfig'); //eslint-disable-line no-unused-vars -const applyOptionsCallback = require('../utils/apply-options-callback'); -const pluginFeatures = require('../features'); -const babelLoaderUtil = require('../loaders/babel'); - /** * Support for ESLint. * @@ -25,6 +18,13 @@ const babelLoaderUtil = require('../loaders/babel'); */ module.exports = function(plugins, webpackConfig) { if (webpackConfig.useEslintPlugin) { + const forceSync = require('sync-rpc'); + const hasEslintConfiguration = forceSync(require.resolve('../utils/has-eslint-configuration')); + const WebpackConfig = require('../WebpackConfig'); //eslint-disable-line no-unused-vars + const applyOptionsCallback = require('../utils/apply-options-callback'); + const pluginFeatures = require('../features'); + const babelLoaderUtil = require('../loaders/babel'); + pluginFeatures.ensurePackagesExistAndAreCorrectVersion('eslint_plugin'); if (!hasEslintConfiguration(webpackConfig)) { From ca95954141d1d11bde19c7db6c35b1aff61891de Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Mon, 19 Dec 2022 20:59:14 -0500 Subject: [PATCH 2/2] moving most require back to the top --- lib/plugins/eslint.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/plugins/eslint.js b/lib/plugins/eslint.js index 2291411e..4bf4e3ae 100644 --- a/lib/plugins/eslint.js +++ b/lib/plugins/eslint.js @@ -9,6 +9,12 @@ 'use strict'; +const forceSync = require('sync-rpc'); +const WebpackConfig = require('../WebpackConfig'); //eslint-disable-line no-unused-vars +const applyOptionsCallback = require('../utils/apply-options-callback'); +const pluginFeatures = require('../features'); +const babelLoaderUtil = require('../loaders/babel'); + /** * Support for ESLint. * @@ -18,12 +24,7 @@ */ module.exports = function(plugins, webpackConfig) { if (webpackConfig.useEslintPlugin) { - const forceSync = require('sync-rpc'); const hasEslintConfiguration = forceSync(require.resolve('../utils/has-eslint-configuration')); - const WebpackConfig = require('../WebpackConfig'); //eslint-disable-line no-unused-vars - const applyOptionsCallback = require('../utils/apply-options-callback'); - const pluginFeatures = require('../features'); - const babelLoaderUtil = require('../loaders/babel'); pluginFeatures.ensurePackagesExistAndAreCorrectVersion('eslint_plugin');