From 5c165c9c6b9f683039b3c9d4592bf6c58840cdd9 Mon Sep 17 00:00:00 2001
From: Yu Takada <yu.smc.roundabout@gmail.com>
Date: Thu, 29 Aug 2024 14:58:03 +0900
Subject: [PATCH 1/3] delete: unused scss files

---
 src/styles/style.scss            | 28 ----------------------------
 src/styles/variables/layout.scss |  3 ---
 src/styles/variables/main.scss   |  1 -
 3 files changed, 32 deletions(-)
 delete mode 100644 src/styles/style.scss
 delete mode 100644 src/styles/variables/layout.scss
 delete mode 100644 src/styles/variables/main.scss

diff --git a/src/styles/style.scss b/src/styles/style.scss
deleted file mode 100644
index 84d8abbb..00000000
--- a/src/styles/style.scss
+++ /dev/null
@@ -1,28 +0,0 @@
-//vuetifyで実現できないスタイルのみ書く。必要最低限で
-
-@import './variables/main.scss';
-
-* {
-  box-sizing: border-box;
-}
-
-//c is the abbreviation of 'customized'
-.c {
-  &__wrapper {
-    display: flex;
-  }
-
-  &__left-sidebar {
-    width: $l_leftSidebarWidth;
-  }
-
-  &__right-sidebar {
-    width: $l_rightSidebarWidth;
-  }
-
-  &__main-area {
-    margin: 0 $l_mainAreaSideMargin;
-    width: calc(100% - (#{$l_leftSidebarWidth} + #{$l_rightSidebarWidth} + (#{$l_mainAreaSideMargin * 2})));
-  }
-}
-
diff --git a/src/styles/variables/layout.scss b/src/styles/variables/layout.scss
deleted file mode 100644
index 89006c3e..00000000
--- a/src/styles/variables/layout.scss
+++ /dev/null
@@ -1,3 +0,0 @@
-$l_leftSidebarWidth: 240px;
-$l_rightSidebarWidth: 300px;
-$l_mainAreaSideMargin: 20px;
diff --git a/src/styles/variables/main.scss b/src/styles/variables/main.scss
deleted file mode 100644
index 67ebf406..00000000
--- a/src/styles/variables/main.scss
+++ /dev/null
@@ -1 +0,0 @@
-@import './layout.scss';

From 1355df823791cd9a30d992d8a932951d47fd1523 Mon Sep 17 00:00:00 2001
From: Yu Takada <yu.smc.roundabout@gmail.com>
Date: Thu, 29 Aug 2024 14:59:23 +0900
Subject: [PATCH 2/3] feat: remove overflow y scroll from the dataset list

---
 .../components/DatasetManager/DatasetManager.vue           | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/presentation/components/DatasetManager/DatasetManager.vue b/src/presentation/components/DatasetManager/DatasetManager.vue
index 9c23599b..e7849357 100644
--- a/src/presentation/components/DatasetManager/DatasetManager.vue
+++ b/src/presentation/components/DatasetManager/DatasetManager.vue
@@ -15,14 +15,13 @@
     </h4>
     <v-list
       density="compact"
-      height="20vh"
-      class="overflow-y-auto mb-5 mt-1 pa-0"
-      style="outline: solid 1px gray"
+      class="mb-5 mt-1 pa-0"
+      style="min-height: 154px; outline: solid 1px gray"
     >
       <v-list-item
         v-for="dataset in datasetRepository.datasets"
         :key="dataset.id"
-        class="pl-2"
+        class="pl-2 c__dataset-item"
         link
         @click="handleOnClickDataset(dataset.id)"
         :class="

From 98b52966356916ff946496626b7e73c8e7f3e949 Mon Sep 17 00:00:00 2001
From: Yu Takada <yu.smc.roundabout@gmail.com>
Date: Thu, 29 Aug 2024 15:07:01 +0900
Subject: [PATCH 3/3] feat: remove active dataset without confirmation if the
 active dataset doesn't have data points

---
 .../DatasetManager/DatasetManager.vue         | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/presentation/components/DatasetManager/DatasetManager.vue b/src/presentation/components/DatasetManager/DatasetManager.vue
index e7849357..0d396902 100644
--- a/src/presentation/components/DatasetManager/DatasetManager.vue
+++ b/src/presentation/components/DatasetManager/DatasetManager.vue
@@ -116,18 +116,23 @@ export default defineComponent({
       this.datasetRepository.createNewDataset()
       this.activateDataset(this.datasetRepository.lastDatasetId)
     },
-    handleOnClickRemoveDatasetButton() {
-      if (
-        !window.confirm(
-          'Are you sure to delete this dataset? This operation is irreversible.',
-        )
-      )
-        return
+    removeActiveDataset() {
       this.interpolator.isActive && this.interpolator.clearPreview()
       this.datasetRepository.removeDataset(
         this.datasetRepository.activeDatasetId,
       )
     },
+    handleOnClickRemoveDatasetButton() {
+      //NOTE: remove active dataset without confirmation if the active dataset doesn't have data points
+      if (this.datasetRepository.activeDataset.plots.length === 0) {
+        this.removeActiveDataset()
+        return
+      }
+
+      window.confirm(
+        `Are you sure to delete '${this.datasetRepository.activeDataset.name}'? This operation is irreversible.`,
+      ) && this.removeActiveDataset()
+    },
   },
 })
 </script>