You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that we have to call 'interpolator.resizeCanvas' in the component each time when the main canvas scale is changed.
This can easily cause a bug of the gap between main canvas drawing and the interpolation canvas drawing by forgetting to call the function above when the new feature is added.
To-Be
If we can create a new class in the application layer, which manages the main canvas scale, the interpolation canvas scale and so on at one time, the problem above should be avoided.
Note
Be careful with the dependency to each applications: use a certain method (e.g. constructor injection) to keep the application testable.
The text was updated successfully, but these errors were encountered:
As-Is
I noticed that we have to call 'interpolator.resizeCanvas' in the component each time when the main canvas scale is changed.
This can easily cause a bug of the gap between main canvas drawing and the interpolation canvas drawing by forgetting to call the function above when the new feature is added.
To-Be
If we can create a new class in the application layer, which manages the main canvas scale, the interpolation canvas scale and so on at one time, the problem above should be avoided.
Note
Be careful with the dependency to each applications: use a certain method (e.g. constructor injection) to keep the application testable.
The text was updated successfully, but these errors were encountered: