Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an application to handle canvas scale and things around that (e.g. interpolated line) #141

Open
yu-smc opened this issue Feb 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@yu-smc
Copy link
Collaborator

yu-smc commented Feb 16, 2024

As-Is

I noticed that we have to call 'interpolator.resizeCanvas' in the component each time when the main canvas scale is changed.
This can easily cause a bug of the gap between main canvas drawing and the interpolation canvas drawing by forgetting to call the function above when the new feature is added.

To-Be

If we can create a new class in the application layer, which manages the main canvas scale, the interpolation canvas scale and so on at one time, the problem above should be avoided.

Note

Be careful with the dependency to each applications: use a certain method (e.g. constructor injection) to keep the application testable.

@yu-smc yu-smc added the enhancement New feature or request label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant