Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Cyclomatic Complexity to lint stage on GitHub action #214

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

t29mato
Copy link
Owner

@t29mato t29mato commented Oct 31, 2024

Update eslint configuration to include complexity rule and ignore test files

Update eslint configuration to include complexity rule and ignore test files
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
starrydigitizer ⬜️ Ignored (Inspect) Oct 31, 2024 7:46am

@t29mato
Copy link
Owner Author

t29mato commented Oct 31, 2024

Confirm that GitHub action fails when Eslint got error

Increase complexity threshold to 20

- Updated the `complexity` rule in the `.eslintrc.cjs` file to set the maximum complexity threshold to 20 instead of 10.
- Modified the `lint` script in the `package.json` file to include `.vue` files in the linting process.
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.95%. Comparing base (2a5f457) to head (596b4b3).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #214   +/-   ##
========================================
  Coverage    42.95%   42.95%           
========================================
  Files           30       30           
  Lines          994      994           
  Branches       149      149           
========================================
  Hits           427      427           
  Misses         566      566           
  Partials         1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Updated the lint command in package.json to include .vue files in the eslint check.
@t29mato t29mato merged commit c65b77b into develop Oct 31, 2024
8 checks passed
@t29mato t29mato changed the title Update eslint configuration Integrate Cyclomatic Complexity to lint stage on GitHub action Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant