Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed 'dep_check' test with cost of 'add' in RV32I larger than 1 #314

Open
moonjohn-hpe opened this issue Aug 30, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@moonjohn-hpe
Copy link

Describe the bug
To test the cascade of dependent instructions in 'dep_check', the cost of 'add' in RV32I is modified to 2 by SetCost(2) according to the caption in 'dep_check.c'. However, the test is failed with 'Timeout' message.

To Reproduce
All issues must be accompanied by:

  • sst --version: SST-Core Version (13.0.0)
  • sst-config --CXX: g++
  • sst-config --ELEMENT_CXXFLAGS: -std=c++17 -fPIC -DHAVE_CONFIG_H -I/home/moonjo/project/sst13/local/sstcore-13.0.0/include
  • The source code branch being used: devel
  • The last commit hash: c3dee3c
  • The compiler utilized to build Rev: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
  • The compiler utilized to build the test: riscv64-unknown-elf-gcc (gc891d8dc23e) 13.2.0
  • The python or JSON simulation input
  • C/CXX test source (or mention which test in the current source tree failed): dep_check

Expected behavior
The cost of 'add' in RV32I can be set to a value larger than 1 according to the caption in 'dep_check.c'. With an addition of 'SetCost(2)' in 'RV32I.h', it is supposed to run the test successfully and report eff less than 100%.

Trace
If applicable, post a trace of the execution.

Additional context
Add any other context about the problem here.

@jleidel
Copy link
Contributor

jleidel commented Aug 30, 2024

@moonjohn-hpe what branch of Rev are you using?

@jleidel jleidel added the bug Something isn't working label Aug 30, 2024
@moonjohn-hpe
Copy link
Author

It happens in both 'main' and 'devel' branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants