Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taiko-client): client changes for ontake fork #17746

Merged
merged 102 commits into from
Jul 26, 2024
Merged

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Jul 5, 2024

ref: #17734

dantaik and others added 2 commits July 4, 2024 16:50
#17679)

BEGIN_COMMIT_OVERRIDE
feat(protocol): allow contract proposers to use calldata as well
feat(protocol): add preconfirmation support based on Brecht's PR (with some renaming) to implement #14793
feat(protocol): add proposeBlock2 in TaikoL1.sol and approve2 in GuardianProver.sol to be used post a fork
refactor(protocol): avoid writing livenessBond to storage to remove unnecessary SSTORE and SLOAD.
refactor(protocol): enable AddressManager to cache address(0) without reading from storage
END_COMMIT_OVERRIDE
Copy link

feat(taiko-client): client changes for ontake fork

Generated at commit: 1a4d5ce762da8950788c62891fc3df27e609b078

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@davidtaikocha davidtaikocha enabled auto-merge July 26, 2024 06:34
@YoGhurt111
Copy link
Contributor

There's one thing that hasn't been done yet. Changes about basefeeAdjustmentQuotient, basefeeSharingPctg, blockGasIssuance.
Will it be done in this PR or the next one? @davidtaikocha

@davidtaikocha
Copy link
Member Author

There's one thing that hasn't been done yet. Changes about basefeeAdjustmentQuotient, basefeeSharingPctg, blockGasIssuance. Will it be done in this PR or the next one? @davidtaikocha

Lets do the basefee stuffs in the next PR, this one is too big now.

@davidtaikocha davidtaikocha added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 2aabf3d Jul 26, 2024
6 checks passed
@davidtaikocha davidtaikocha deleted the ontake_fork_client branch July 26, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants