Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents of XMM registers should be preserved during VM-exit handling #5

Closed
tandasat opened this issue Mar 11, 2016 · 2 comments
Closed

Comments

@tandasat
Copy link
Owner

As it is reported in #3, HyperPlatform does not preserve contents of XMM registers when VM-exit occurs. This can corrupt guest's context if a VM-exit handler modifies XMM registers and a guest uses those modified values, and result in unexpected failure in a guest (most likely system crash).

In order to avoid this issue, the VMM should probably save contents of XMM registers on VM-exit, and restore them before VM-enter so that modification of those registers by the VMM does not leak to guest's state.

@tandasat tandasat changed the title Use of XMM registers in a VM-exit handler may corrupt guest's context Contents of XMM registers should be preserved during VM-exit handling Mar 11, 2016
@tandasat
Copy link
Owner Author

As of now, no update is planed since any issue due to modified XMM registers has not seen yet. If you faced this issue, please flag it up so that this bug can be prioritized.

@tandasat
Copy link
Owner Author

already fixed with 7bcb1a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant