BCH calculations numeric precision fix

tatumio · Jul 13, 2020 · 9ba6e71 · 9ba6e71
1 parent 9b99a78
commit 9ba6e71
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tatumio/tatum",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "",
   "main": "dist/src/index.js",
   "repository": "https://github.com/tatumio/tatum-js",

diff --git a/src/offchain/bcash.ts b/src/offchain/bcash.ts
@@ -64,12 +64,12 @@ export const prepareBitcoinCashSignedOffchainTransaction =
         });
 
         const lastVin = data.find(d => d.vIn === '-1') as WithdrawalResponseData;
-        tx.addOutput(address, Number(new BigNumber(amount).multipliedBy(100000000).toFixed(8, BigNumber.ROUND_FLOOR)));
+        tx.addOutput(address, Number(new BigNumber(amount).multipliedBy(100000000).toFixed(0, BigNumber.ROUND_FLOOR)));
         if (mnemonic) {
             const {xpub} = generateBchWallet(testnet, mnemonic);
-            tx.addOutput(generateAddressFromXPub(Currency.BCH, testnet, xpub, 0), Number(new BigNumber(lastVin.amount).multipliedBy(100000000).toFixed(8, BigNumber.ROUND_FLOOR)));
+            tx.addOutput(generateAddressFromXPub(Currency.BCH, testnet, xpub, 0), Number(new BigNumber(lastVin.amount).multipliedBy(100000000).toFixed(0, BigNumber.ROUND_FLOOR)));
         } else if (keyPair && changeAddress) {
-            tx.addOutput(changeAddress, Number(new BigNumber(lastVin.amount).multipliedBy(100000000).toFixed(8, BigNumber.ROUND_FLOOR)));
+            tx.addOutput(changeAddress, Number(new BigNumber(lastVin.amount).multipliedBy(100000000).toFixed(0, BigNumber.ROUND_FLOOR)));
         } else {
             throw new Error('Impossible to prepare transaction. Either mnemonic or keyPair and attr must be present.');
         }
@@ -78,7 +78,7 @@ export const prepareBitcoinCashSignedOffchainTransaction =
             if (input.vIn === '-1') {
                 continue;
             }
-            const value = Number(data[i].amount) * 100000000;
+            const value = Number(new BigNumber(data[i].amount).multipliedBy(100000000).toFixed(0, BigNumber.ROUND_FLOOR));
             if (mnemonic) {
                 const derivationKey = input.address && input.address.derivationKey ? input.address.derivationKey : 0;
                 const privateKey = await generatePrivateKeyFromMnemonic(Currency.BCH, testnet, mnemonic, derivationKey);

diff --git a/src/transaction/bcash.ts b/src/transaction/bcash.ts
@@ -31,10 +31,10 @@ export const prepareBitcoinCashSignedTransaction = async (testnet: boolean, body
     for (const [i, item] of fromUTXO.entries()) {
         transactionBuilder.addInput(item.txHash, item.index);
         privateKeysToSign.push(item.privateKey);
-        amountToSign.push(Number(new BigNumber(item.value).multipliedBy(100000000).toFixed(8, BigNumber.ROUND_FLOOR)));
+        amountToSign.push(Number(new BigNumber(item.value).multipliedBy(100000000).toFixed(0, BigNumber.ROUND_FLOOR)));
     }
     for (const item of to) {
-        transactionBuilder.addOutput(item.address, Number(new BigNumber(item.value).multipliedBy(100000000).toFixed(8, BigNumber.ROUND_FLOOR)));
+        transactionBuilder.addOutput(item.address, Number(new BigNumber(item.value).multipliedBy(100000000).toFixed(0, BigNumber.ROUND_FLOOR)));
     }
 
     for (let i = 0; i < privateKeysToSign.length; i++) {